[PATCH] D85599: [PowerPC] Remove isTerminator for TRAP instruction

nemanjai added a comment. Herald added a project: All. I think we should handle this similarly to `SITargetLowering::splitKillBlock()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85599/new/ https://reviews.llvm.org/D85599 __

[PATCH] D85599: [PowerPC] Remove isTerminator for TRAP instruction

shchenz added a comment. With this change, we get verify failure for below case: int test_builtin_trap(int num) { volatile int i = 0; if (num > 0) __builtin_unreachable(); else goto L1; L1: return i; } clang t.c -target powerpc-unknown-unknown -c -mllvm -verif

[PATCH] D85599: [PowerPC] Remove isTerminator for TRAP instruction

ZhangKang added a comment. In D85599#2206033 , @efriedma wrote: > Fixing a MachineVerifier issue by patching clang is generally wrong; if the > IR is valid, the backend should do something sane with it. If the IR isn't > valid, the IR Verifier should co