[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

2020-11-30 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfdbd84c6c819: [clang][Fuchsia] Add relative-vtables multilib (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://rev

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

2020-11-19 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 ___ c

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

2020-11-19 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. *ping* any more comments on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

2020-10-19 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 299138. leonardchan edited the summary of this revision. leonardchan added a comment. Updated to use the `-fexperimental-relative-c++-ab-vtables` flag now that D85802 was reverted. This will be used for the purpose of te

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

2020-10-14 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. > This change implement a slightly different approach from what we discussed, > which is providing an Itanium-compatible (that is `-fc++abi=itanium`) > multilib for compatibility with other compilers, and then enabling relative > vtables by default. Unless there's a

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

2020-10-14 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D85576#2330923 , @leonardchan wrote: > This should also be ready now that https://reviews.llvm.org/D85802 landed, > unless we don't want to submit this *right* now so the clang builders don't > build these multilibs that won't

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

2020-10-14 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. This should also be ready now that https://reviews.llvm.org/D85802 landed, unless we don't want to submit this *right* now so the clang builders don't build these multilibs that won't be used yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

2020-08-12 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 285219. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/lib/

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

2020-08-10 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 284573. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Drive

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

2020-08-07 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. This adds a multilib for Fuchsia that is built with the relative vtables ABI. This depend