[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

2020-08-10 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers abandoned this revision. nickdesaulniers added a comment. refixing in https://reviews.llvm.org/D80242 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85565/new/ https://reviews.llvm.org/D85565

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

2020-08-07 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/test/CodeGen/debug-info-unused-types.cpp:1-5 +// RUN: %clangxx --target=x86_64-linux-gnu -fno-eliminate-unused-debug-types -g -emit-llvm -S -o - %s | FileCheck %s +// RUN: %clangxx --target=x86_64-linux-gnu -fno-eliminate-unused-

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

2020-08-07 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. I'm just going to revert cbd8ec93709376fbf404c99f4eee399790e26db7 and e486921fd6cf96ae9114adac455f7c0b5c1088a7 and sort t

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

2020-08-07 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. I think this could be problematic when building a Clang without an X86 target, unless you also mark X86 REQUIRED (at least in the CodeGen tests). Would using cc1 and hardcoding --debug-info-kind=limited (or something like that) work, too? Repository: rG LLVM Github M

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

2020-08-07 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added reviewers: dblaikie, mschifer. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers requested review of this revision. Tests added in https://reviews.llvm.org/D80242 https://reviews.llvm.org/rGcbd8ec9370