[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

2020-08-10 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_18.cpp:5 + +///==/// +// RUN: %clang_cc1 -DUSE -DCK19 -verify -fopenmp -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -triple p

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

2020-08-07 Thread Artem Belevich via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd01980f308a: [OpenMP] Split OpenMP/target_map_codegen test [NFC] (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

2020-08-07 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_18.cpp:5 + +///==/// +// RUN: %clang_cc1 -DUSE -DCK19 -verify -fopenmp -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -tri

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

2020-08-07 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85551/new/ https://reviews.llvm.org/D85551 ___ c

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

2020-08-07 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_18.cpp:5 + +///==/// +// RUN: %clang_cc1 -DUSE -DCK19 -verify -fopenmp -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -triple p

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

2020-08-07 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D85551#2203758 , @tra wrote: > In D85551#2203711 , @jdoerfert wrote: > >> Wow, cool. I imagine it was hard to split this given the manual check lines. >> We really need to start using

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

2020-08-07 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D85551#2203711 , @jdoerfert wrote: > Wow, cool. I imagine it was hard to split this given the manual check lines. > We really need to start using the upgrade scripts here. > > I'm fine with this, @ABataev WDYT? It was not that har

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

2020-08-07 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Wow, cool. I imagine it was hard to split this given the manual check lines. We really need to start using the upgrade scripts here. I'm fine with this, @ABataev WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85551/

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

2020-08-07 Thread Artem Belevich via Phabricator via cfe-commits
tra created this revision. tra added a reviewer: ABataev. Herald added subscribers: sanjoy.google, bixia, guansong, yaxunl. Herald added a project: clang. tra requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. The test file is the single lon