[PATCH] D85471: Make clang HIP headers compatible with C++98

arsenm added a comment. Can you either 1. Add test coverage 2. Delete this entirely Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85471/new/ https://reviews.llvm.org/D85471 ___ cfe-commits mailing list

[PATCH] D85471: Make clang HIP headers compatible with C++98

arsenm added a comment. Herald added a project: All. I don't understand why this is necessary. What does cmake have to do with it? Is HIP just not defaulting to the correct default C++ standard? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85471/n

[PATCH] D85471: Make clang HIP headers compatible with C++98

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac3e720dc1af: Make clang HIP headers compatible with C++98 (authored by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85471: Make clang HIP headers compatible with C++98

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85471/new/ https://reviews.llvm.org/D85471 _

[PATCH] D85471: Make clang HIP headers compatible with C++98

scchan created this revision. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. scchan requested review of this revision. Automation to detect compiler features, such as CMake's target_compile_features, would attempt to detect compiler features by explicitly using lan