[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

2020-08-12 Thread Anastasia Stulova via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3c8a4ee0764c: [OpenCL] Remove warning for variadic macros in C++ for OpenCL. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

2020-08-11 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new/ https://reviews.llvm.org/D85429 ___ cfe-commits mailing list c

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

2020-08-07 Thread Ole Strohm via Phabricator via cfe-commits
olestrohm updated this revision to Diff 283909. olestrohm added a comment. I have amended the relevant test to validate this behaviour in C++ for OpenCL. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new/ https://reviews.llvm.org/D85429 Files: clang/lib/Lex/PPDirectives.cpp c

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

2020-08-06 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. Can you extend test test/Preprocessor/macro_variadic.cl to cover C++ for OpenCL mode, otherwise LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new/ https://reviews.llvm.org/D85429

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

2020-08-06 Thread Ole Strohm via Phabricator via cfe-commits
olestrohm created this revision. olestrohm added a reviewer: Anastasia. olestrohm added a project: clang. Herald added subscribers: cfe-commits, yaxunl. olestrohm requested review of this revision. C++ for OpenCL intends to support variadic macros, a decision motivated by OpenCL 3.0. This patch s