This revision was automatically updated to reflect the committed changes.
Closed by commit rG3c8a4ee0764c: [OpenCL] Remove warning for variadic macros in
C++ for OpenCL. (authored by Anastasia).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85429/new
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85429/new/
https://reviews.llvm.org/D85429
___
cfe-commits mailing list
c
olestrohm updated this revision to Diff 283909.
olestrohm added a comment.
I have amended the relevant test to validate this behaviour in C++ for OpenCL.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85429/new/
https://reviews.llvm.org/D85429
Files:
clang/lib/Lex/PPDirectives.cpp
c
Anastasia added a comment.
Can you extend test test/Preprocessor/macro_variadic.cl to cover C++ for OpenCL
mode, otherwise LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85429/new/
https://reviews.llvm.org/D85429
olestrohm created this revision.
olestrohm added a reviewer: Anastasia.
olestrohm added a project: clang.
Herald added subscribers: cfe-commits, yaxunl.
olestrohm requested review of this revision.
C++ for OpenCL intends to support variadic macros, a decision motivated by
OpenCL 3.0. This patch s