This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2ff44935a5f5: [clangd] Reduce availability of extract
function (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:291
+ llvm::SmallSet DeclsInExtZone;
+ for (const Node *Child : ExtZone.Parent->Children) {
+auto *RootStmt = Child->ASTNode.get();
sammccall wrote:
> I
kadircet updated this revision to Diff 296110.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85354/new/
https://reviews.llvm.org/D85354
Files:
clang-tools-ex
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:281
+
+ // Make sure declarations inside extraction zone are not accessed afterwards.
+ /
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous.
Herald added a project: clang.
kadircet requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
This patch introduces hoisting det
