[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-27 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan added inline comments. Comment at: clang/test/Preprocessor/init-zos.c:4 + +// S390X-ZOS-GNUXX:#define _EXT 1 +// S390X-ZOS:#define _LONG_LONG 1 MaskRay wrote: > --match-full-lines is different from --match-full-lines --strict-whitespace.

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Preprocessor/init-zos.c:4 + +// S390X-ZOS-GNUXX:#define _EXT 1 +// S390X-ZOS:#define _LONG_LONG 1 --match-full-lines is different from --match-full-lines --strict-whitespace. You can freely add leading and t

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-25 Thread Hubert Tong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG97ccf93b3615: [SystemZ][z/OS] Add z/OS Target and define macros (authored by abhina.sreeskantharajan, committed by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-25 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan added a comment. In D85324#2234712 , @hubert.reinterpretcast wrote: > In D85324#2233290 , > @abhina.sreeskantharajan wrote: > >> Thanks Hubert, I fixed the comment. > > Got it; I'll look in

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-24 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. In D85324#2233290 , @abhina.sreeskantharajan wrote: > Thanks Hubert, I fixed the comment. Got it; I'll look into committing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-24 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan updated this revision to Diff 287338. abhina.sreeskantharajan added a comment. Thanks Hubert, I fixed the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85324/new/ https://reviews.llvm.org/D85324 Files: clang/lib/

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-21 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM from my end; although @MaskRay might want another look. Comment at: clang/lib/Basic/Targets/OSTargets.h:758 + Builder.defineMacro("_

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-21 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan marked 5 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:743 +Builder.defineMacro("__BFP__"); +// FIXME: __BOOL__ should be defined under strict -std=c89. +Builder.defineMa

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-21 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan updated this revision to Diff 287043. abhina.sreeskantharajan added a comment. Thanks for reviewing. I've updated the comments and removed ISOC99_SOURCE macro. I've updated the lit test to reflect these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:743 +Builder.defineMacro("__BFP__"); +// FIXME: __BOOL__ should be defined under strict -std=c89. +Builder.defineMacro("__BOOL__"); MaskRay wrote: > What is

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:743 +Builder.defineMacro("__BFP__"); +// FIXME: __BOOL__ should be defined under strict -std=c89. +Builder.defineMacro("__BOOL__"); What is strict -std=c89? `!Opts.C99` ?

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan marked 3 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:743 +Builder.defineMacro("__BFP__"); +Builder.defineMacro("__BOOL__"); +Builder.defineMacro("__LONGNAME__"); --

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan updated this revision to Diff 286853. abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added a comment. Thanks Hubert, I updated the comments, and also the check-prefix to your suggestion. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/test/Preprocessor/init-zos.c:5 +// +// S390X-ZOS-CXX:#define _EXT 1 +// S390X-ZOS-C99:#define _ISOC99_SOURCE 1 Should this be `GNUXX`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:736 +MacroBuilder &Builder) const override { +// FIXME: LONG_LONG should not be defined under -std=c89 +Builder.defineMacro("_LONG_LONG"); Mi

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-17 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/test/Preprocessor/init.c:1041 // +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=s390x-none-zos -fno-signed-char < /dev/null | FileCheck -match-full-line

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-17 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan updated this revision to Diff 286092. abhina.sreeskantharajan added a comment. Thanks MaskRay. I moved the zos testcase to a new file called init-zos.c instead and reduced the number of RUN commands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Preprocessor/init.c:1041 // +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=s390x-none-zos -fno-signed-char < /dev/null | FileCheck -match-full-lines -check-prefix S390X-ZOS %s +// RUN: %clang_cc1 -x c -E -dM -ffreestandi

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-17 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan updated this revision to Diff 286014. abhina.sreeskantharajan added a comment. Addressed Hubert's comments, and removed some macros that are unnecessary with system header updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-17 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:730 +MacroBuilder &Builder) const override { +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_OPEN_DEFAULT"); hubert.reinterpretca

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-13 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:730 +MacroBuilder &Builder) const override { +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_OPEN_DEFAULT"); The comment from http