[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

MaskRay added a comment. The file is auto-generated by: `path/to/clang-tblgen -gen-opt-docs -I clang/include/clang/Driver -I llvm/include/ clang/include/clang/Driver/ClangOptionDocs.td > clang/docs/ClangCommandLineReference.rst` The description is retrieved from `DocBrief`. It `DocBrief` does n

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

psmith added a comment. I agree it's not what I'd like. I'm not sure how to react to MaskRays comment. The top of the ClangCommandLineReference.rst says: --- NOTE: This file is automatically generated by running clang-tblgen -

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

probinson added a comment. Whoa--that's the *help* text? Well, if that's the only documentation for options that there is, I guess it has to go there; but it seems pretty excessive for the (ideally concise) output of `clang --help`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

This revision was automatically updated to reflect the committed changes. psmith marked an inline comment as done. Closed by commit rG839d974ee0e4: [DOCS] Add more detail to stack protector documentation (authored by psmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo C

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

psmith marked an inline comment as done. psmith added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2139 -Enable stack protectors for some functions vulnerable to stack smashing. This uses a loose heuristic which considers functions vulnerable if they c

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

psmith updated this revision to Diff 283201. psmith added a comment. Herald added a subscriber: dang. uploaded diff with both Options.td and ClangCommandLineReference.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85239/new/ https://reviews.llvm.org/D85239 Files: clang/docs/ClangC

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

psmith added a comment. In D85239#2194604 , @MaskRay wrote: > This file is auto generated. The real documentation should go to > `clang/include/clang/Driver/Options.td` Thanks for pointing that out! I regenerated the ClangCommandLineReference.rst from O

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

MaskRay added a comment. This file is auto generated. The real documentation should go to `clang/include/clang/Driver/Options.td` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85239/new/ https://reviews.llvm.org/D85239 ___ cfe-commits mailin

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

probinson added a comment. Looks okay (one grammar nit), probably worth waiting for someone else to chime in. Comment at: clang/docs/ClangCommandLineReference.rst:2139 -Enable stack protectors for some functions vulnerable to stack smashing. This uses a loose heuristic whic

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

psmith created this revision. psmith added reviewers: jfb, Shayne, emaste, kristof.beyls, mattdr, ojhunt, probinson, reames, serge-sans-paille, dim. Herald added a subscriber: dexonsmith. psmith requested review of this revision. The Clang -fstack-protector documentation mentions what functions a