[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rG351aac098543: [Sema] Add casting check for fixed to fixed point conversions (authored by vabridgers, committed by einvbri ). Changed prior to commit: https://reviews.llvm

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

bjope accepted this revision. bjope added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D85157 ___ cf

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers marked 4 inline comments as done. vabridgers added a comment. All comments marked as done. ok to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D85157

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/test/Sema/warn-bad-function-cast.c:49 +#ifdef FIXED_POINT + (void)(_Fract) if1(); // no warning +#endif bjope wrote: > bjope wrote: > > vabridgers wrote: > > > bjope

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers updated this revision to Diff 283858. vabridgers added a comment. address Bjorn's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D85157 Files: clang/lib/Sema/SemaCast.cpp clang/test/Sema/wa

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

bjope added inline comments. Comment at: clang/test/Sema/warn-bad-function-cast.c:49 +#ifdef FIXED_POINT + (void)(_Fract) if1(); // no warning +#endif bjope wrote: > vabridgers wrote: > > bjope wrote: > > > bjope wrote: > > > > bjope wrote: > > > > > This should

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers added a comment. Ping! Ok to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D85157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers added a subscriber: bevinh. vabridgers added a comment. ok, I think it's all sorted out now. Thanks @bevinh for the desk review. Let's start at the beginning again :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://revi

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers updated this revision to Diff 282902. vabridgers edited the summary of this revision. vabridgers added a comment. ok, I think it's all sorted out now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D851