kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/XRefs.cpp:241
auto AddResultDecl = [&](const NamedDecl *D) {
+// FIXME: C++ global operator new/delete are impli
hokein added a comment.
> please note that this might require special handling for go-to-def. as
> go-to-def only jumps to canonical decl and in operator new's case the user
> provided one might not be canonical, whereas the canonical one is likely
> builtin without a source info.
this is a go
hokein updated this revision to Diff 282509.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85028/new/
https://reviews.llvm.org/D85028
Files:
clang-tools-extra/clangd/FindTarget.cpp
clang-tools-extra/cl
kadircet added a comment.
please note that this might require special handling for go-to-def. as
go-to-def only jumps to canonical decl and in operator new's case the user
provided one might not be canonical, whereas the canonical one is likely
builtin without a source info.
also you have a ty
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:466-467
+ }
+ void VisitCXXDeleteExpr(const CXXDeleteExpr *CNE) {
+Outer.add(CNE->getOperatorDelete(), Flags);
+ }
nit:
Repository:
rG LLVM Github Monor
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, jkorous.
Herald added a project: clang.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Repository:
rG LLVM Github Monorepo
https://reviews
