[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

2020-08-07 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1d782942500b: [Sema][BFloat] Forbid arithmetic on vectors of bfloat. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85009/new/ ht

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

2020-08-06 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham added a comment. This discussion seems to have wound down. I'll land this patch tomorrow on the strength of @LukeGeeson's review, unless you have strong objections, @jfb? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85009/new/ https:

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

2020-08-03 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham added a comment. In D85009#2187643 , @jfb wrote: > Language-wise I think https://wg21.link/p1467 is where C++ is going, and C is > taking a similar approach. That doesn't seem to mention vectors at all. As I said on Friday, I wouldn't disag

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

2020-07-31 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. In D85009#2187631 , @LukeGeeson wrote: > In D85009#2187621 , @jfb wrote: > >> In D85009#2187603 , @simon_tatham >> wrote: >> >>> In D85009#2187549

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

2020-07-31 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham added a comment. In D85009#2187621 , @jfb wrote: > You mean: only aarch64 backend supports lowering bfloat16 vectors at the > moment? Yes, sorry – I should have said that Arm has the only implementation //in an LLVM target//. I meant the on

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

2020-07-31 Thread Luke Geeson via Phabricator via cfe-commits
LukeGeeson added a comment. In D85009#2187621 , @jfb wrote: > In D85009#2187603 , @simon_tatham > wrote: > >> In D85009#2187549 , @jfb wrote: >> >>> Is that true of all vect

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

2020-07-31 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. In D85009#2187603 , @simon_tatham wrote: > In D85009#2187549 , @jfb wrote: > >> Is that true of all vector bfloat implementations? It seems like arithmetic >> on these types is something imple

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

2020-07-31 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham added a comment. In D85009#2187549 , @jfb wrote: > Is that true of all vector bfloat implementations? It seems like arithmetic > on these types is something implementations would likely support. As I understand it, Arm currently has the only

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

2020-07-31 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. Is that true of all vector bfloat implementations? It seems like arithmetic on these types is something implementations would likely support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85009/new/ https://reviews.llvm.org/D8

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

2020-07-31 Thread Luke Geeson via Phabricator via cfe-commits
LukeGeeson accepted this revision. LukeGeeson added a comment. This revision is now accepted and ready to land. This seems sensible and benign, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85009/new/ https://reviews.llvm.org/D85009 _

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

2020-07-31 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham created this revision. simon_tatham added reviewers: SjoerdMeijer, rjmccall, rsmith, liutianle, RKSimon, craig.topper, jfb, LukeGeeson, fpetrogalli. Herald added subscribers: cfe-commits, dexonsmith, kristof.beyls. Herald added a project: clang. simon_tatham requested review of this r