[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

steakhal added a comment. In D84979#2190996 , @balazske wrote: > Really I am still not totally familiar how the checkers work and if it is > good to have these function names. Yea, naming things is pretty hard. I'm open to have a less verbose one - espe

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

steakhal updated this revision to Diff 286212. steakhal marked 2 inline comments as done. steakhal edited the summary of this revision. steakhal added a comment. Herald added a subscriber: mgorny. Fixed Artem's inline comments: - `cstring::getCStringLength` now takes `StateRef` by value - `cstrin

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringLength.h:42 +LLVM_NODISCARD Optional +getCStringLength(CheckerContext &Ctx, const ProgramStateRef &State, SVal Buf); + Just pass by value then. It's already a "Ref".

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

balazske added a comment. Really I am still not totally familiar how the checkers work and if it is good to have these function names. I was thinking about any checker that needs a string length information. It could get the data from CStringChecker using a "get" function or test if there is da

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

steakhal added a comment. It seems the Pre-merge clang-format went crazy. I think just ignore the lint warnings for the unchanged lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84979/new/ https://reviews.llvm.org/D84979 _

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus, xazax.hun, baloghadamsoftware, vsavchenko, martong, gamesh411. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Herald added a pro