[PATCH] D84939: [clangd] Propagate remote index errors via Expected

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb5588b0ad59: [clangd] Propagate remote index errors via Expected (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:313 RelativePath, llvm::sys::path::Style::posix)); - if (RelativePath.empty()) { -return llvm::None; - } - if (llvm::sys::path::is_a

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev updated this revision to Diff 282166. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Good points, thanks! Addressed post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84939/new/ https://reviews.llvm.or

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:313 RelativePath, llvm::sys::path::Style::posix

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:313 RelativePath, llvm::sys::path::Style::posix)); - if (RelativePath.empty()) { -return llvm::None; - } - if (llvm::sys::path::is_a

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev updated this revision to Diff 281946. kbobyrev marked 12 inline comments as done. kbobyrev added a comment. Resolve most review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84939/new/ https://reviews.llvm.org/D84939 Files: cl

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev added a comment. In D84939#2184836 , @kadircet wrote: > i think you might want to have an helper for creating stringerrors and use it > in all places Haha, yeah I thought about that but then looked at other examples and saw that in some cases t

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kadircet added a comment. i think you might want to have an helper for creating stringerrors and use it in all places Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:60 + Response.takeError()); +llvm::consumeError(Response.takeError());

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev updated this revision to Diff 281897. kbobyrev added a comment. Client: print debug string for the stream_result, not the ReplyT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84939/new/ https://reviews.llvm.org/D84939 Files: clang-tool

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a refactoring: errors shoul