[PATCH] D84902: [clang-tidy] Fix ODR violation in unittests.

2020-07-30 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6a043ecc0cf4: [clang-tidy] Fix ODR violation in unittests. (authored by dergachev.a). Herald added a subscriber: steakhal. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D84902: [clang-tidy] Fix ODR violation in unittests.

2020-07-30 Thread Nathan James via Phabricator via cfe-commits
njames93 accepted this revision. njames93 added a comment. LGTM, Thanks that bug was eating away at me for a good few days. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84902/new/ https://reviews.llvm.org/D84902 ___

[PATCH] D84902: [clang-tidy] Fix ODR violation in unittests.

2020-07-30 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. LGTM! Thanks for all the investigative work! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84902/new/ https://reviews.llvm.org/D84902 __

[PATCH] D84902: [clang-tidy] Fix ODR violation in unittests.

2020-07-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: alexfh, gribozavr, dcoughlin, delcypher, yln, kubamracek, vsavchenko, njames93. Herald added subscribers: martong, mgehre, Charusso, xazax.hun. NoQ requested review of this revision. I debugged the problem from D84453