This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa262f0fea46c: [clangd] Implement Relations request for
remote index (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
kbobyrev updated this revision to Diff 281869.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Address post-LGTM comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84894/new/
https://reviews.llvm.org/D84894
Files:
clang-
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp:391
+ auto Deserialized = ProtobufMarshaller.fromProtobuf(*Serialized);
+ ASSER
kbobyrev updated this revision to Diff 281863.
kbobyrev marked 6 inline comments as done.
kbobyrev added a comment.
Address all comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84894/new/
https://reviews.llvm.org/D84894
Files:
clang-tools
kadircet added a comment.
thanks mostly nits, only annoying bit is usage of optionals and multi-logging
but letting them be for now :D.
also looks like there are some irrelevant changes, e.g. auto's in lambdas or
formatting in protos, feel free to land an NFC change(without review) for those
b
kbobyrev updated this revision to Diff 281754.
kbobyrev added a comment.
Fix comment in proto file and rebase on top of master.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84894/new/
https://reviews.llvm.org/D84894
Files:
clang-tools-extra/cla
kbobyrev created this revision.
kbobyrev added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous.
Herald added a project: clang.
kbobyrev requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
This is the last missing bit in the
