[PATCH] D84591: [clang-tidy][NFC] Replace comment by private method

2020-07-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. In D84591#2174473 , @hanneskaeufler wrote: > In D84591#2174447 , @aaron.ballman > wrote: > > > In D84591#2174442

[PATCH] D84591: [clang-tidy][NFC] Replace comment by private method

2020-07-26 Thread Hannes Käufler via Phabricator via cfe-commits
hanneskaeufler added a comment. In D84591#2174447 , @aaron.ballman wrote: > In D84591#2174442 , @hanneskaeufler > wrote: > > > In D84591#2174437 , @aaron.ballman > > wrote

[PATCH] D84591: [clang-tidy][NFC] Replace comment by private method

2020-07-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D84591#2174442 , @hanneskaeufler wrote: > In D84591#2174437 , @aaron.ballman > wrote: > > > LGTM! > > > Awesome, thanks! Do you need someone to commit on your behalf? If so, can

[PATCH] D84591: [clang-tidy][NFC] Replace comment by private method

2020-07-26 Thread Hannes Käufler via Phabricator via cfe-commits
hanneskaeufler added a comment. In D84591#2174437 , @aaron.ballman wrote: > LGTM! Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84591/new/ https://reviews.llvm.org/D84591

[PATCH] D84591: [clang-tidy][NFC] Replace comment by private method

2020-07-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84591/new/ https://reviews.llvm.org/D84591