hctim added a comment.
Hi folks, looks like this patch broke `check-clang` under ASan/MSan, would you
mind taking a look? Thanks.
FAIL: Clang :: Driver/darwin-dsymutil.c (6208 of 24675)
TEST 'Clang :: Driver/darwin-dsymutil.c' FAILED
Script:
--
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7209f83112db: Allow .dSYM's to be directly placed in an
alternate directory (authored by dsanders).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84572/new/
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84572/new/
https://reviews.llvm.org/D84572
__
dsanders updated this revision to Diff 281376.
dsanders added a comment.
Remove external- prefix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84572/new/
https://reviews.llvm.org/D84572
Files:
clang/include/clang/Driver/Options.td
clang/lib/Dr
dsanders marked an inline comment as done.
dsanders added inline comments.
Comment at: clang/include/clang/Driver/Options.td:693
def e : JoinedOrSeparate<["-"], "e">, Group;
+def external_dsym_dir : JoinedOrSeparate<["-"], "external-dsym-dir">,
+ Flags<[DriverOption, RenderAsIn
JDevlieghere added inline comments.
Comment at: clang/include/clang/Driver/Options.td:693
def e : JoinedOrSeparate<["-"], "e">, Group;
+def external_dsym_dir : JoinedOrSeparate<["-"], "external-dsym-dir">,
+ Flags<[DriverOption, RenderAsInput]>,
Could we drop t
dsanders updated this revision to Diff 280653.
dsanders added a comment.
Attempt to fix the windows-specific failure by using posix-style path::append()
That feels wrong but it's consistent with a test in the same file that already
passes because the path manipulation is an extension append
(bar/
dsanders created this revision.
dsanders added reviewers: beanz, bogner.
Herald added a reviewer: JDevlieghere.
Herald added subscribers: cfe-commits, dang.
Herald added a project: clang.
Once available in the relevant toolchains this will allow us to implement
LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DI
