This revision was automatically updated to reflect the committed changes.
Closed by commit rGc0bd9fa137c2: [Concepts] Fix ast dump for immediately
declared constraint. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84461/new/
ht
hokein updated this revision to Diff 280890.
hokein marked 3 inline comments as done.
hokein added a comment.
address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84461/new/
https://reviews.llvm.org/D84461
Files:
clang/lib/AST/
riccibruno added inline comments.
Comment at: clang/test/AST/ast-dump-concepts.cpp:1
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -std=c++2a -ast-dump
-ast-dump-filter Foo %s | FileCheck -strict-whitespace %s
+
Can you also test for serialization by round-
nridge added inline comments.
Comment at: clang/test/AST/ast-dump-concepts.cpp:12
+ template R>
+ Foo(R) requires(true);
+};
another nit: the `requires(true)` is not relevant to the testcase.
(Although, perhaps it is another bug that it does not appear in the
nridge added inline comments.
Comment at: clang/test/AST/ast-dump-concepts.cpp:4
+template
+concept not_same_as = true;
+
nit: perhaps use a more generic name like `binary_concept` (meaning concept
that takes two types)
Repository:
rG LLVM Github Monorepo
hokein created this revision.
hokein added a reviewer: rsmith.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D84461
Files:
clang/lib/AST/TextNodeDumper.cpp
clang/test/AST/ast-dump-concepts.cpp
Index: clang/test/AST/ast-dump-concepts.cpp
=
