[PATCH] D84455: [Concepts] Fix a deserialization crash.

aaronpuchert added a comment. > in some cases (e.g. implicit deduction guide templates synthesized from the > constructor), hasTypeConstraint returns true, and getTypeConstraint returns a > nullptr. If that's the case, can we reproduce this with a parsed AST? I've only seen this error on deser

[PATCH] D84455: [Concepts] Fix a deserialization crash.

This revision was automatically updated to reflect the committed changes. Closed by commit rG73c12bd8ff1a: [Concepts] Fix a deserialization crash. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D84455?vs=280225&id=281811#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D84455: [Concepts] Fix a deserialization crash.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. In D84455#2170461 , @hokein wrote: > btw, `getTypeConstraint` and `hasTypeConstraint` APIs are quite easy to be > misused (there is another similar bug

[PATCH] D84455: [Concepts] Fix a deserialization crash.

hokein added a comment. btw, `getTypeConstraint` and `hasTypeConstraint` APIs are quite easy to be misused (there is another similar bug in getAssociatedConstraints ), I think we need to refine

[PATCH] D84455: [Concepts] Fix a deserialization crash.

hokein created this revision. hokein added a reviewer: rsmith. Herald added a subscriber: kristof.beyls. Herald added a project: clang. `TemplateTypeParmDecl::hasTypeConstraint` is not a safe guard for checking `TemplateTypeParmDecl::getTypeConstraint()` result is null. in somecases (e.g. implici