[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

2020-07-27 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D84453#2171548 , @njames93 wrote: > I was having issues with this test case under macos in D82188 > . > It would fail for seemingly no apparent reason until I disable a test in a > different transl

[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

2020-07-24 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. I was having issues with this test case under macos in D82188 . It would fail for seemingly no apparent reason until I disable a test in a different translation unit. This made me think there is a subtle bug in the linker used on macos.

[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

2020-07-23 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. LGTM, thanks for taking care of this! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84453/new/ https://reviews.llvm.org/D84453 ___

[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

2020-07-23 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: alexfh, gribozavr, dcoughlin, delcypher, yln, kubamracek, vsavchenko. Herald added subscribers: martong, mgehre, Charusso, xazax.hun. It's failing on macOS under AddressSanitizer for no obvious reason - i.e., no report is produced, just the code is