[PATCH] D84343: [AST] Keep FP options in trailing storage of CallExpr

2020-07-23 Thread Serge Pavlov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG70e7aa4a4ed3: [AST][FPEnv] Keep FP options in trailing storage of CallExpr (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84343/new/

[PATCH] D84343: [AST] Keep FP options in trailing storage of CallExpr

2020-07-23 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84343/new/ https://reviews.llvm.org/D84343 __

[PATCH] D84343: [AST] Keep FP options in trailing storage of CallExpr

2020-07-23 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 280040. sepavloff added a comment. Extended test with PCH read Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84343/new/ https://reviews.llvm.org/D84343 Files: clang/include/clang/AST/Expr.h clang/include

[PATCH] D84343: [AST] Keep FP options in trailing storage of CallExpr

2020-07-22 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added inline comments. Comment at: clang/test/AST/ast-dump-fpfeatures.cpp:1 +// RUN: %clang_cc1 -fsyntax-only %s -std=c++11 -ast-dump | FileCheck %s + Can you also test the serialization by round-tripping through a PCH (see the other AST dump tests fo

[PATCH] D84343: [AST] Keep FP options in trailing storage of CallExpr

2020-07-22 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff created this revision. sepavloff added reviewers: rjmccall, mibintc. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: clang. This change allow a CallExpr to have optional FPOptionsOverride object, stored in trailing storage. The implementaion i