[PATCH] D84202: [clang][noderef] Enable -Wnoderef warning for CXX C-style casts

aaron.ballman added a comment. In D84202#2179718 , @leonardchan wrote: > In D84202#2179618 , @aaron.ballman > wrote: > >>> users can still disable the warning on line granularity with pragmas. >> >> This makes me a

[PATCH] D84202: [clang][noderef] Enable -Wnoderef warning for CXX C-style casts

leonardchan added a comment. In D84202#2179618 , @aaron.ballman wrote: >> users can still disable the warning on line granularity with pragmas. > > This makes me a bit uncomfortable because those pragmas extremely ugly (and > not easily portable). Also,

[PATCH] D84202: [clang][noderef] Enable -Wnoderef warning for CXX C-style casts

aaron.ballman added a comment. > users can still disable the warning on line granularity with pragmas. This makes me a bit uncomfortable because those pragmas extremely ugly (and not easily portable). Also, this will break code for users who were previously doing something that was explicitly a

[PATCH] D84202: [clang][noderef] Enable -Wnoderef warning for CXX C-style casts

leonardchan created this revision. leonardchan added reviewers: aaron.ballman, rsmith. leonardchan added a project: clang. We find it more valuable to warn on all instances we're removing the `noderef` attribute from a pointer. This patch removes the type holes where we initially didn't warn on