[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8572 if (PartialStruct.Base.isValid()) +CurInfo.NonContigInfo.Dims.push_back(0); emitCombinedEntry(CombinedInfo, CurInfo.Types, PartialStruct); MaskRay wrote: >

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

MaskRay added a comment. > map item can be non-contiguous for target update The subject appears to describe a situation, but patch subjects should usually be imperative Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8572 if (PartialStruct.Base.isValid()) +Cu

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cab91140f61: [OpenMP5.0] map item can be non-contiguous for target update (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 303495. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/Diagnost

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D84192#2172482 , @cchen wrote: > @ABataev, do I need to wait for the runtime patch to commit this one? If so, > do you have some recommend reviewers for me to add to that patch? I have > pinged several times for that patch but

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev, do I need to wait for the runtime patch to commit this one? If so, do you have some recommend reviewers for me to add to that patch? I have pinged several times for that patch but haven't got many reviews for it. Thanks! Repository: rG LLVM Github Monorepo C

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 ___

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 280474. cchen added a comment. Fix coding style and argument on getIntTypeForBitwidth Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/Ope

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8914 + ASTContext &C = CGF.getContext(); + QualType Int64Ty = C.getIntTypeForBitwidth(/*DestWidth=*/64, /*Signed=*/true); + RecordDecl *RD; 1. The second argument must be of inte

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev, is there any other concern for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 ___ cfe-commits mailing list cfe-com

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2167649 , @ABataev wrote: > In D84192#2167636 , @cchen wrote: > > > In D84192#2165522 , @ABataev wrote: > > > > > In D84192#2165517

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D84192#2167636 , @cchen wrote: > In D84192#2165522 , @ABataev wrote: > > > In D84192#2165517 , @cchen wrote: > > > > > In D84192#2165438

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165522 , @ABataev wrote: > In D84192#2165517 , @cchen wrote: > > > In D84192#2165438 , @ABataev wrote: > > > > > In D84192#2165396

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D84192#2165517 , @cchen wrote: > In D84192#2165438 , @ABataev wrote: > > > In D84192#2165396 , @cchen wrote: > > > > > In D84192#2165249

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165438 , @ABataev wrote: > In D84192#2165396 , @cchen wrote: > > > In D84192#2165249 , @ABataev wrote: > > > > > In D84192#2165235

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D84192#2165396 , @cchen wrote: > In D84192#2165249 , @ABataev wrote: > > > In D84192#2165235 , @cchen wrote: > > > > > In D84192#2164885

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165249 , @ABataev wrote: > In D84192#2165235 , @cchen wrote: > > > In D84192#2164885 , @ABataev wrote: > > > > > Also, what about compatibil

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165249 , @ABataev wrote: > In D84192#2165235 , @cchen wrote: > > > In D84192#2164885 , @ABataev wrote: > > > > > Also, what about compatibil

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D84192#2165235 , @cchen wrote: > In D84192#2164885 , @ABataev wrote: > > > Also, what about compatibility with declare mapper? Can you add tests for > > it? > > > There's a restriction f

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 279631. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2164885 , @ABataev wrote: > Also, what about compatibility with declare mapper? Can you add tests for it? There's a restriction for map clause that non-contiguous is not allowed and I guess it also applies to declare map

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Also, what about compatibility with declare mapper? Can you add tests for it? Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7809-7813 +MapValuesArrayTy CurOffsets{llvm::ConstantInt::get(CGF.CGM.Int64Ty, 0)}; +MapValuesArrayTy CurCounts{llvm:

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. In order not to modify the `tgt_target_data_update` information but still be able to pass the extra in