[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

2020-07-21 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. In D84090#2162389 , @MyDeveloperDay wrote: > Nit:clang-format the patch > > Here is a Tip as to what I do (In case it helps other): > > 1. I generate the diff off the staged items so I've already git added all the > files I'm

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

2020-07-21 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. just reopening to formally accept Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84090/new/ https://reviews.llvm.org/D84090 __

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

2020-07-21 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a subscriber: djasper. MyDeveloperDay added a comment. > Thanks for assistance and review. And sorry about the extra noise. No worries on my part about the noise, firstly this was a really nice clean, quick review but also the noise is part of the learning for us all (especi

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

2020-07-20 Thread Anders Waldenborg via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG52ab7aa0ba5a: [clang-format] Add BitFieldColonSpacing option (authored by wanders). Repository: rG LLVM Github Monorepo

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

2020-07-20 Thread Anders Waldenborg via Phabricator via cfe-commits
wanders added a comment. In D84090#2162389 , @MyDeveloperDay wrote: > 2. then I can do `git clang-format`, this will fix up any files in the diff > that need formatting (you'll need to git add them again if they have) (I use https://github.com/kimgr/gi

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

2020-07-20 Thread Anders Waldenborg via Phabricator via cfe-commits
wanders updated this revision to Diff 279279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84090/new/ https://reviews.llvm.org/D84090 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

2020-07-20 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Nit:clang-format the patch Here is a Tip as to what I do (In case it helps other): 1. I generate the diff off the staged items so I've already git added all the files I'm working on. 2. then I can do `git clang-format`, this will fix up any files in the diff th

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

2020-07-20 Thread Anders Waldenborg via Phabricator via cfe-commits
wanders updated this revision to Diff 279237. wanders retitled this revision from "[clang-format] Add SpaceAroundBitFieldColon option" to "[clang-format] Add BitFieldColonSpacing option". wanders edited the summary of this revision. wanders added a comment. Renamed option to "BitFieldColonSpacin