atrosinenko added a reviewer: atrosinenko.
atrosinenko added a comment.
If I get it right, the only thing this patch weakens about msp430-toolchain.c
test is an assumption that libgcc is used by default.
On one hand, now there is no `clang_rt.builtins` for MSP430, so testing this
assumption mak
saugustine added a comment.
This is a reasonable workaround, as it seems to be checking the position of
various arguments, and as things work today, lgcc and the compiler-rt variants
appear in exactly the same places.
If we wanted to be really strict, we would add some new test that tested that
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5d06e8b24f97: Pass -rtlib=libgcc in tests conditioned on the
default. (authored by stellaraccident).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84058/new/
stellaraccident updated this revision to Diff 278865.
stellaraccident added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84058/new/
https://reviews.llvm.org/D84058
Files:
clang/test/Driver/msp430-toolchain.c
Index: clang/tes
echristo added a reviewer: saugustine.
echristo added a comment.
(Adding Sterling as well)
I think this will be an OK workaround for now, go ahead and reply on the main
thread as I think they'll want to set the default runtime library as part of
the toolchain. I'm surprised at this behavior as w
stellaraccident created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
- This test was failing in our builds that configure compiler-rt as the
configure-time rtlib.
- Opted for this test fix instead of a rollback, and hopefully TI can fix
forward if this we
