[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:568 +#if 0 +void fu^nc(); +#endif sammccall wrote: > kadircet wrote: > > nit: i am not sure if this is worth it's own test > Moved into CommonAncestor te

[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

This revision was automatically updated to reflect the committed changes. Closed by commit rG72f2fb1db4ea: [clangd] Exclude preprocessed-to-nothing tokens from selection (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84012/new

[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

sammccall marked an inline comment as done. sammccall added inline comments. Herald added a subscriber: kbobyrev. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:568 +#if 0 +void fu^nc(); +#endif kadircet wrote: > nit: i am not sure

[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

sammccall updated this revision to Diff 278717. sammccall marked 3 inline comments as done. sammccall edited the summary of this revision. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84012/new/ https://

[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/Selection.cpp:228 + Buf.expansionsAffecting(Sel)) { + if (X.Expanded.empty()) { +for (const syntax