[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 ___ cfe-commi

[PATCH] D83914: [clangd] Plan features for FoldingRanges

hokein added a comment. just some random comments from my side. > At least for the AST-based folds, I'd like some formalism like: +1. I think we need some general rules (mental model) to guide us how the folding works. Some editors (e.g. VSCode) have their builtin folding-range, it is worth to

[PATCH] D83914: [clangd] Plan features for FoldingRanges

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:329 + )cpp", + // Argument lists. + R"cpp( kbobyrev wrote: > sammccall wrote: > > missing lambdas, blocks, objc methods. > > cover bodies in

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:246 + + if ([[B && I > 42 || ~([[++I]])]]) {[[ +++I; sammccall wrote: > confused about [[++I]] - why is this foldable but not I > 42 etc

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev updated this revision to Diff 279132. kbobyrev marked 13 inline comments as done. kbobyrev added a comment. Resolve most comments, make sure everything builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.o

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev planned changes to this revision. kbobyrev added a comment. Will resolve the comments and add some missing examples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 __

[PATCH] D83914: [clangd] Plan features for FoldingRanges

sammccall added a comment. A few different types of feedback mixed up here :-) Some nitpicks about behavior: these are probably worth discussing. Places where the coverage is incomplete: obviously until we get closer to implementation, how complete this is is up to you. Looking at examples mos

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev updated this revision to Diff 278329. kbobyrev added a comment. Add some missing ranges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 Files: clang-tools-extra/clangd/unittests/SemanticSelectio

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev updated this revision to Diff 278327. kbobyrev added a comment. Fix some typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 Files: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cp

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is not an actual patch, this is an RFC + TDD plan for future RAV implementation. Hopeful