[PATCH] D83901: [clang] Disable a few formatting options for test/

2020-07-19 Thread Bruno Ricci via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG13316a770535: [clang] Disable a few formatting options for test/ (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83901/new/ https://

[PATCH] D83901: [clang] Disable a few formatting options for test/

2020-07-17 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. In D83901#2155127 , @MyDeveloperDay wrote: > clang-format -n warnings before this change in clang/test/Analysis/*.cpp > (clang-format -n *.cpp |& grep warning | wc -l) > > before = 6903 vs after=6595, if it helps I'd say thi

[PATCH] D83901: [clang] Disable a few formatting options for test/

2020-07-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added reviewers: rsmith, dblaikie. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this is a good improvement, but you should wait for a few days in case other reviewers have feedback. Repository: rG L

[PATCH] D83901: [clang] Disable a few formatting options for test/

2020-07-16 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. clang-format -n warnings before this change in clang/test/Analysis/*.cpp (clang-format -n *.cpp |& grep warning | wc -l) before = 6903 vs after=6595, if it helps I'd say this looks good. Most a very brief review of changes seem to be mainly whitespace/extra lin

[PATCH] D83901: [clang] Disable a few formatting options for test/

2020-07-15 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno created this revision. riccibruno added reviewers: aaron.ballman, jdoerfert, lebedev.ri, MyDeveloperDay. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Hopefully this will make the bot a little less noisy. Rationale for each: `AlignTrailingComments`: We don