vsavchenko added a comment.
Additionally, I would prefer commit message to be imperative. It is sorta like
a rule of a good commit message.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83836/new/
https://reviews.llvm.org/D83836
__
vsavchenko added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:97
+// If a region is removed all of the subregions needs to be removed too.
+static ProgramStateRef removeTrackedRegions(ProgramStateRef State,
nit: *need to b
vrnithinkumar marked 2 inline comments as done.
vrnithinkumar added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:189-190
+// or rvalue references.
+// In case of an InstanceCall don't invalidate the this-region since
+// it is fu
vrnithinkumar updated this revision to Diff 278207.
vrnithinkumar edited the summary of this revision.
vrnithinkumar added a comment.
Untrack all changing regions in checkRegionChanges
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83836/new/
https:
xazax.hun added inline comments.
Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:962
+ operator bool() const;
+ unique_ptr &operator=(unique_ptr &&p);
+};
vrnithinkumar wrote:
> added this to support use case like `Q = std::move(P)`
This o
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:189-190
+// or rvalue references.
+// In case of an InstanceCall don't invalidate the this-region since
+// it is fully handled in checkPreCall and checkPostCall.
+const
vrnithinkumar marked 3 inline comments as done.
vrnithinkumar added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:180
+ProgramStateRef SmartPtrModeling::checkRegionChanges(
+ProgramStateRef State, const InvalidatedSymbols *Invalidated,
