[PATCH] D83788: Removed unused variable in clang

dblaikie closed this revision. dblaikie added a comment. In D83788#2183684 , @hiraditya wrote: > Not sure why this didnt get closed after the patch is merged in: > https://reviews.llvm.org/rG4fd91b0f946f49370a3ab33c480a807a3f48b247 The commit didn't cont

[PATCH] D83788: Removed unused variable in clang

hiraditya added a comment. Not sure why this didnt get closed after the patch is merged in: https://reviews.llvm.org/rG4fd91b0f946f49370a3ab33c480a807a3f48b247 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788

[PATCH] D83788: Removed unused variable in clang

hiraditya accepted this revision. hiraditya added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D83788: Removed unused variable in clang

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. No problem, thanks for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 ___ cfe-comm

[PATCH] D83788: Removed unused variable in clang

nadav added a comment. @modocache Thank you for the review. I updated the permissions of the diff. Sorry, for the trouble. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 ___ cfe-commits mailing lis

[PATCH] D83788: Removed unused variable in clang

nadav updated this revision to Diff 278031. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 Files: clang/lib/Sema/SemaExpr.cpp Index: clang/lib/Sema/SemaExpr.cpp === --- clang/lib

[PATCH] D83788: Removed unused variable in clang

modocache added a comment. By the way, I tried to accept this diff and leave the following inline comment on `SemaExpr.cpp:15799`: > I guess this assert was never capable of being hit previously, since the > `FixItHint::isNull` would always return true? I wonder if we'll now see some > genuine

[PATCH] D83788: Removed unused variable in clang

modocache added a comment. This LGTM! Looks like the last time this variable was touched was in 2010 as part of a mechanical renaming, https://github.com/llvm/llvm-project/commit/a771f46c82d7. At that point it was used, as a parameter to the static function `MakeObjCStringLiteralFixItHint`. Th