This revision was automatically updated to reflect the committed changes.
Closed by commit rGdbf486c0de92: [clangd] Config: Index.Background (authored by
sammccall).
Changed prior to commit:
https://reviews.llvm.org/D83768?vs=277844&id=277885#toc
Repository:
rG LLVM Github Monorepo
CHANGES
kadircet accepted this revision.
kadircet marked an inline comment as done.
kadircet added a comment.
This revision is now accepted and ready to land.
let's ship it!
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:196
constexpr static llvm::SourceMgr::DiagKind Error =
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:196
constexpr static llvm::SourceMgr::DiagKind Error = llvm::SourceMgr::DK_Error;
+ constexpr static llvm::SourceMgr::DiagKind Warning =
+ llvm::SourceMgr::DK_Warning;
---
sammccall updated this revision to Diff 277844.
sammccall marked 5 inline comments as done.
sammccall added a comment.
Address some comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83768/new/
https://reviews.llvm.org/D83768
Files:
clang-to
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:98
+ ValidValues.push_back(Name);
+ if (!Result && *Input == Name)
+Result = Value;
should we assert on multiple matches of the same name ?
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
We only support Build/Skip for now, but with 'Load' or similar as an
option for future (load existing
