[PATCH] D83759: [clangd] Port lit tests to Windows

ArcsinX updated this revision to Diff 279482. ArcsinX added a comment. Revert tests split; Replace '\' with '/' in background-index.test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 Files: clang-tools

[PATCH] D83759: [clangd] Port lit tests to Windows

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:18 # Test that the index is writing files in the expected location. # RUN: ls %t/.cache/clangd/index/foo.cpp.*.idx # RUN: ls %t/sub_dir/.cache/clangd/index/foo.h.*.idx -

[PATCH] D83759: [clangd] Port lit tests to Windows

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:18 # Test that the index is writing files in the expected location. # RUN: ls %t/.cache/clangd/index/foo.cpp.*.idx # RUN: ls %t/sub_dir/.cac

[PATCH] D83759: [clangd] Port lit tests to Windows

kadircet added a comment. hi, sorry for the late replay :/ We discussed this offline with Sam and are both concerned with the duplications it introduces, haven't really thought about a nice way to address this yet. As you mentioned the background-index test in itself looks a lot better do, so

[PATCH] D83759: [clangd] Port lit tests to Windows

njames93 added a comment. In D83759#2163622 , @ArcsinX wrote: > What do you think of this patch? I'm not sure if Windows is important OS for > developers. Windows is most certainly an important OS for developers and something the whole llvm project has

[PATCH] D83759: [clangd] Port lit tests to Windows

ArcsinX added a comment. What do you think of this patch? I'm not sure if Windows is important OS for developers, and that some of these changes might be awkward to maintain, but maybe we can enable `background-index.test` at least? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D83759: [clangd] Port lit tests to Windows

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Changes: - `background-index.test` Add Windows support. - `dependency-output.test` Split into two tests (Windows and Posix). - `did