This revision was automatically updated to reflect the committed changes.
Closed by commit rG13c9bbc28ef9: [clang-tidy] Refactor IncludeInserter
(authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83680/new/
https://reviews.llvm.or
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83680/new/
https://reviews.llvm.org/D83680
njames93 updated this revision to Diff 278807.
njames93 marked 5 inline comments as done.
njames93 added a comment.
Address reviewer comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83680/new/
https://reviews.llvm.org/D83680
Files:
clang-t
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/IncludeInserter.cpp:55
IncludeSorter &IncludeInserter::getOrCreate(FileID FileID) {
+ assert(SourceMgr && "SourceMgr shouldn't be null");
// std::unique_ptr is cheap to construct, so force a
njames93 created this revision.
njames93 added reviewers: aaron.ballman, alexfh, klimek.
Herald added subscribers: cfe-commits, arphaman, kbarton, xazax.hun, nemanjai.
Herald added a project: clang.
Simplified how `IncludeInserter` is used in Checks by abstracting away the
SourceManager and PPCal
