This revision was automatically updated to reflect the committed changes.
Closed by commit rG015a0faa5e9e: [clangd] Fix hover crash on InitListExpr.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D83546?vs=277016&id=277031#toc
Repository:
rG LLVM Github Monorepo
CHA
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83546/new/
https://reviews.llvm.org/D83546
__
hokein added inline comments.
Comment at: clang-tools-extra/clangd/Hover.cpp:345
+if (!ILE->isSemanticForm())
+ E = ILE->getSemanticForm();
+ }
kadircet wrote:
> shouldn't we put this before `QualType T = E->getType();` ?
ah, I think you're right. put i
hokein updated this revision to Diff 277016.
hokein marked 2 inline comments as done.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83546/new/
https://reviews.llvm.org/D83546
Files:
clang-tools-extra/cla
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/Hover.cpp:345
+if (!ILE->isSemanticForm())
+ E = ILE->getSemanticForm();
+ }
shouldn't we put this before `QualType T = E->getType();` ?
Repository:
rG LLVM Github Monorepo
CHANGE
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
Fixes https://github.com/clangd/clangd/issues/455
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D83546
