[PATCH] D83511: [clangd] Config: If.PathExclude

2020-07-10 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D83511#2143803 , @sammccall wrote: > BTW I'm **not** planning to add Suffix/SuffixExclude in the immediate future, > at least for clangd 11 people will have to use `PathMatch: '.*\.h'` or so. > Sound OK? yeah, that sounds goo

[PATCH] D83511: [clangd] Config: If.PathExclude

2020-07-10 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG86f1313424fb: [clangd] Config: If.PathExclude (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D83511?vs=276839&id=277000#toc Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D83511: [clangd] Config: If.PathExclude

2020-07-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added a comment. BTW I'm **not** planning to add Suffix/SuffixExclude in the immediate future, at least for clangd 11 people will have to use `PathMatch: '.*\.h'` or so. Sound OK? Comment at: clang-tools-extra/clangd/unitt

[PATCH] D83511: [clangd] Config: If.PathExclude

2020-07-09 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp:73 + Frag.If.PathMatch.emplace_back("b.*"); + Frag.If.PathExclude.emplace_back(".*r"); + EXPECT_F

[PATCH] D83511: [clangd] Config: If.PathExclude

2020-07-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83511 Files: clang-tools-e