This revision was automatically updated to reflect the committed changes.
Closed by commit rG3cca818efabb: Refactored NumericLiteralParser to not require
a Preprocessor (authored by gribozavr).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83480/new/
gribozavr2 added inline comments.
Comment at: clang/include/clang/Lex/LiteralSupport.h:57-59
- NumericLiteralParser(StringRef TokSpelling,
- SourceLocation TokLoc,
- Preprocessor &PP);
eduucaldas wrote:
> We don't need
gribozavr updated this revision to Diff 276740.
gribozavr added a comment.
Addressed code review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83480/new/
https://reviews.llvm.org/D83480
Files:
clang/include/clang/Lex/LiteralSupport.h
eduucaldas accepted this revision.
eduucaldas added a comment.
This revision is now accepted and ready to land.
Additionally, consider applying a similar change to `CharLiteralParser`, for
consistency.
All the comments are just suggestions. Feel free to land this without answering
them.
gribozavr created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We would like to use NumericLiteralParser in the implementation of the
syntax tree builder, and plumbing a preprocessor there seems
inconvenient and superfluous.
Repository:
rG LLVM Github M
