Szelethus added a comment.
I don't like this solution t much, but I respect the urgency, and since we
don't introduce a compatibility issue, I trust we can remove this if we decide
to change to TableGen. Post-commit LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
Szelethus added inline comments.
Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:48-50
#ifndef ANALYZER_OPTION_DEPENDS_ON_USER_MODE
/// Create a new analyzer option, but dont generate a method for it in
/// AnalyzerOptions. It's value depends on the opt
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd12d0b73f1c9: [analyzer] Add CTUImportCppThreshold for C++
files (authored by martong).
Changed prior to commit:
https://reviews.llvm.org/D83475?vs=276722&id=276727#toc
Repository:
rG LLVM Github Mon
martong updated this revision to Diff 276722.
martong marked an inline comment as done.
martong added a comment.
- Remove extra whitespace
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83475/new/
https://reviews.llvm.org/D83475
Files:
clang/incl
gamesh411 added inline comments.
Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:333
+"for import when inlining functions during CTU analysis of C++
"
+"source files. ",
8u)
extra whitespac
gamesh411 accepted this revision.
gamesh411 added a comment.
This revision is now accepted and ready to land.
It will be interesting to see how different C and C++ projects will prove in
terms of AST complexity, and Decl-size, but I understand that for now, these
two options are necessary to not
martong created this revision.
martong added reviewers: gamesh411, Szelethus.
Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso,
dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet,
baloghadamsoftware, xazax.hun, whisperity.
Herald added a project: clang.
The
