[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG96a5cfff208d: [AST][RecoveryExpr] Fix the value category for recovery expr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83201/new/ h

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12944 + Fn->getBeginLoc(), RParenLoc, SubExprs, + ReturnType.isNull() + ? ReturnType sammccall wrote: > hokein wrote: > > sammccall wrote: > > > here we're splitting the

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

hokein updated this revision to Diff 276379. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83201/new/ https://reviews.llvm.org/D83201 Files: clang/lib/AST/Expr.cp

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprClassification.cpp:147 + case Expr::RecoveryExprClass: +return ClassifyExprValueKind(Lang, E, E->getValueKind()); -

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12944 + Fn->getBeginLoc(), RParenLoc, SubExprs, + ReturnType.isNull() + ? ReturnType sammccall wrote: > here we're splitting the type (e.g. int&&) into a type + VK, and p

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

hokein updated this revision to Diff 276325. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83201/new/ https://reviews.llvm.org/D83201 Files: clang/lib/AST/Expr.cpp

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12944 + Fn->getBeginLoc(), RParenLoc, SubExprs, + ReturnType.isNull() + ? ReturnType here we're splitting the type (e.g. int&&) into a type + VK, and passing both to

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. RecoveryExpr was always lvalue, but it is wrong if we use it to model broken function calls, function call expression has more compliated rules: - a call to a function whose return type is an lvalue r