This revision was automatically updated to reflect the committed changes.
Closed by commit rG15a60fe09f46: [clangd] Config: compute config in TUScheduler
and BackgroundIndex (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D83095?vs=275388&id=275487#toc
Repository:
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:748
+Context ClangdServer::createProcessingContext(PathRef File) const {
+ if (!ConfigProvider)
kadircet wrote:
> sammccall wrote
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:748
+Context ClangdServer::createProcessingContext(PathRef File) const {
+ if (!ConfigProvider)
sammccall wrote:
> kadircet wrote:
> > why not make this a free function in `C
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83095/new/
https://reviews.llvm.org/D83095
__
sammccall updated this revision to Diff 275387.
sammccall marked 6 inline comments as done.
sammccall added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83095/new/
https://reviews.llvm.org/D83095
Files:
clang-tools-e
sammccall updated this revision to Diff 275388.
sammccall added a comment.
fix -Wreorder
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83095/new/
https://reviews.llvm.org/D83095
Files:
clang-tools-extra/clangd/ClangdServer.cpp
clang-tools-extr
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:748
+Context ClangdServer::createProcessingContext(PathRef File) const {
+ if (!ConfigProvider)
kadircet wrote:
> why not make this a free function in `ConfigProvider.h` ?
>
kadircet added a comment.
LG, mostly nits apart from a question about moving the context generation logic
into a different place.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:748
+Context ClangdServer::createProcessingContext(PathRef File) const {
+ if (!ConfigProv
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
javed.absar, ilya-biryukov.
Herald added a project: clang.
sammccall added a parent revision: D82964: [clangd] Config: loading and caching
config fr
