[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-08 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 276406. DavidSpickett added a subscriber: stevewan. DavidSpickett added a comment. - Write to cmake and clang's default triple to also fix failure reported by @stevewan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-07 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 275950. DavidSpickett added a comment. - Removed \ from regex, not needed for POSIX syntax. - Reflowed text in commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. The description appears to be wrapped at a very small column number. Can you please fix it? Comment at: clang/test/Driver/program-path-priority.c:34 +/// isolated as we expected. +// NO_NOTREAL_GCC-NOT: {{\/gcc[^\/]*"}} `\` can be re

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-02 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 275138. DavidSpickett added a comment. - Added check for alternate gcc names in the first test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055 Files: clang/tes

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-02 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test can fail when the path of the build includes the strings we're checking for. E.g "/gcc" is found in ".../gcc_7.3.0/..." To correct this look for '"' on the end of all matches. So