[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:118 +syntax::NodeKind getOperatorNodeKind(const CXXOperatorCallExpr &E) { + switch (E.getOperator()) { # Where to put this logic? The pro of having this function inside `Buil

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275316. eduucaldas added a comment. Herald added a subscriber: mgorny. Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files: clang/include/clang/AST/ExprCXX.

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275318. eduucaldas added a comment. Revert mistake on last update, used `arc diff --update` with the wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275315. eduucaldas added a comment. - Remove predicates in `CXXOperatorCallExpr`. - Implement getOperatorNodeKind to dispatch from `CXXOperatorCallExpr` to syntax constructs like `BinaryOperatorExpression`, `PrefixUnaryOperatorExpression`... Repository

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/AST/ExprCXX.cpp:82 + default: +return getNumArgs() == 1; + } riccibruno wrote: > This will be true for `operator->`. Thank you ! I had missed that! I'll pro

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

riccibruno added inline comments. Comment at: clang/lib/AST/ExprCXX.cpp:82 + default: +return getNumArgs() == 1; + } This will be true for `operator->`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas added a reviewer: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added a comment. Code that reproduces the crash Notice that when using a postfix unary operator ++ one argument is introduced to differ it from its prefix counterpart, b

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82954 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprCXX.cpp clang/lib/Tooling/Syntax/BuildTree.cpp clang/u