[PATCH] D82844: [clangd] Set gRPC deadlines to all remote index requests

2020-07-01 Thread Kirill Bobyrev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG22a3e4055f43: [clangd] Set gRPC deadlines to all remote index requests (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82844/new/ http

[PATCH] D82844: [clangd] Set gRPC deadlines to all remote index requests

2020-07-01 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 274744. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82844/new/ https://reviews.llvm.org/D82844 Files: clang-to

[PATCH] D82844: [clangd] Set gRPC deadlines to all remote index requests

2020-06-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:63 + std::shared_ptr Channel, + std::chrono::milliseconds DeadlineTime = std::chrono::millise

[PATCH] D82844: [clangd] Set gRPC deadlines to all remote index requests

2020-06-30 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. "TL;DR: Always set a deadline.", https://grpc.io/blog/deadlines/ Repository: rG LLVM Gith