[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

Quuxplusone abandoned this revision. Quuxplusone added a comment. Superseded by D82793 . :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82736/new/ https://reviews.llvm.org/D82736 ___

[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

sammccall added a comment. In D82736#2120089 , @Quuxplusone wrote: > In D82736#2119262 , @sammccall wrote: > > > `viewWithDefaultCWD` suggests to me the default has some semantics which > > don't exist, if using th

[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

Quuxplusone added a comment. In D82736#2119262 , @sammccall wrote: > `viewWithDefaultCWD` suggests to me the default has some semantics which > don't exist, if using this API "shape" I'd substitute `Arbitrary` here I'm naturally 100% fine with that. I c

[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

sammccall added a comment. Yeah, IMO we spent a bunch of time on these names, I still like them, and I don't find the arguments since then convincing. New info is of course the warning, and the lack of consensus to change it at clang level. As for this proposal specifically - `viewWithDefaultC

[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

kadircet added a comment. Thanks, renaming was also another option we had in mind, see https://reviews.llvm.org/D81920#2109901 and possibly the following comments. I thought it was discussed in the disable-the-warning thread, but to elaborate a little more: Naming is hard in general, this case

[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

Quuxplusone created this revision. Quuxplusone added reviewers: sammccall, kadircet, dblaikie. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes an instance of `-Woverloaded-virtual` on GCC. Clarifies the purpose of t