[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

2020-06-29 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Reverted in 7c2cb1448ad2d20e251db5e3ae4a0c84c12aa970 , relanded in 7b8cf98b4a9a2f5ea3667fdbf913a4f8952ed36a

[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

2020-06-27 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. yes let's revert dffc1420451f674 and reland with this change included, also please keep the `Differential Revision: https://reviews.llvm.org/D80681` line on the commit message, so that it gets assoc

[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Alternatively, I could revert dffc1420451f674 , and reland with this hunk? That way if a revert is necessary in the future, it's only one. Also so that before/after metrics are together and not

[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers added a comment. Alternatively, I could revert dffc1420451f674