[PATCH] D82677: [Clang] Handle AIX Include management in the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a2f4824cb2d: [Clang] Handle AIX Include management in the driver (authored by ShuhongL, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a2f4824cb2d: [Clang] Handle AIX Include management in the driver (authored by ShuhongL, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195 + // Return if -nostdlibinc is specified as a driver option. + if (DriverArgs.hasArg(options::OPT_nostdlibinc))

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195 + // Return if -nostdlibinc is specified as a driver option. + if (DriverArgs.hasArg(options::OPT_nostdlibinc)) +return; stevewan wrote: > Can we rewrite this

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

stevewan accepted this revision. stevewan added a comment. LGTM with minor nit. I took a look at the failed tests in premerge checks, they didn't seem to be related, but please double check before you commit. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195 + // Return if

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 275432. ShuhongL added a comment. Add clang -xc tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/T

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. Aside from one comment; LGTM. Thanks. Comment at: clang/test/Driver/aix-toolchain-include.cpp:4 +// Check powerpc-ibm-aix, 32-bit/64-bit. +// RUN: %clangxx -### -no-canonical-prefixes %s 2>&1

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 275396. ShuhongL added a comment. - `nostdlibinc` should not suppress clang builtin headers - Add tests for `nostdlibinc` and `nobuiltininc` - fix lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:179 +ArgStringList &CC1Args) const { + // return if -nostdinc/-nostdlibinc is specified as a driver option. + if (DriverArgs.hasArg(options::OPT_nos

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 275221. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/AIX.h clang/lib/Frontend/InitHeaderS

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL added a comment. Modified changes: 1. Add sysroot 2. return if `options::OPT_nostdlibinc` is specified, and will not add `/usr/local/include` to the path since it's different from other system (linux,darwin etc.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 275220. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/AIX.h clang/lib/Frontend/InitHeaderS

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver &D = getDriver(); daltenty wrote: > hubert.reinterpretcast wrote: > > Please investigate the handling of `OPT_nostdlibinc`. > If we ar

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty requested changes to this revision. daltenty added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver &D = getDriver(); hubert.reinterpretcast wrote: > Please

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:179 + } + addSystemInclude(DriverArgs, CC1Args, "/usr/include"); +} This does not observe `--sysroot`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver &D = getDriver(); Please investigate the handling of `OPT_nostdlibinc`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM other than minor nit Comment at: clang/test/Driver/aix-toolchain-include.cpp:13 + +// Check powerpc-ibm-aix, 64-bit. +// RUN: %clangxx -### -no-canonical-prefixes %s

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 275111. ShuhongL marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolCh

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:8 +// RUN: | FileCheck -check-prefix=CHECK-INTERNAL32-INCLUDE %s +// CHECK-INTERNAL32-INCLUDE: {{.*}}clang{{.*}}" "-cc1" +// CHECK-INTERNAL32-INCLUDE: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 274519. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/AIX.h clang/lib/Frontend/InitHeaderS

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:1 +// Tests that aix toolchain adds system includes to the search path + nit: aix->AIX nit: period at end of comment. Comment at: clang/test/Driver/aix-tool

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL added a comment. Added testcase for the clang toolchain changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 ___ cfe-commits mailing list cfe-commit

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 274210. Herald added a subscriber: ormris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/AIX

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added a comment. Where are the test cases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:167 +void AIX::AddClangSystemIncludeArgs(const ArgList &DriverArgs, +ArgStringList &CC1Args) const { s

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:167 +void AIX::AddClangSystemIncludeArgs(const ArgList &DriverArgs, +ArgStringList &CC1Args) const { I don't think this is the revision you inten

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 273819. ShuhongL retitled this revision from "[AIX] Modify AIX customized clang driver toolchain to include AIX system headers in search path" to "[Clang] Handle AIX Include management in the driver". ShuhongL edited the summary of this revision. Repository