[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

2020-06-29 Thread Daniil Fukalov via Phabricator via cfe-commits
dfukalov abandoned this revision. dfukalov added a comment. I was completely wrong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82650/new/ https://reviews.llvm.org/D82650 ___ cfe-commits mailing list

[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

2020-06-26 Thread Daniil Fukalov via Phabricator via cfe-commits
dfukalov planned changes to this revision. dfukalov added a comment. In D82650#2116849 , @yaxunl wrote: > I think the point of -ffp-contract=fast is that it allows emitting fma across > statements if there are such opportunities whereas -ffp-contract=on o

[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

2020-06-26 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. I think the point of -ffp-contract=fast is that it allows emitting fma across statements if there are such opportunities whereas -ffp-contract=on only allows fma in one statement https://llvm.org/docs/CompileCudaWithLLVM.html#flags-that-control-numerical-code Repositor

[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

2020-06-26 Thread Daniil Fukalov via Phabricator via cfe-commits
dfukalov created this revision. dfukalov added reviewers: yaxunl, b-sumner, rampitec. Herald added subscribers: cfe-commits, Anastasia. Herald added a project: clang. With the FAST default FP_CONTRACT mode' setting for `func(float a, float b, float c) { return a + b * c; }` FE generates pair `fmul