[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e089e98a9d5: [libclang] Fix crash when visiting a captured VLA (authored by ckandeler, committed by jkorous). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler added a comment. In D82629#2134521 , @jkorous wrote: > @ckandeler do you have commit access or do you want me to land the patch? I do not, so it'd be great if you could do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

jkorous added a comment. @ckandeler do you have commit access or do you want me to land the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82629/new/ https://reviews.llvm.org/D82629 ___ cfe-commi

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM! Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82629/new/ https://reviews.llvm.org/D82629

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler added a comment. I suppose it boils down to whether the visit() function is supposed to except null arguments or not. Since I don't know the answer to that, I added the check at the caller. From the description of the linked patch, it appears that other places are also calling the fun

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

milianw added a comment. this relates to https://reviews.llvm.org/D82740 too, but comes with a test which is good. personally I would place the check directly within Visit to make it more generically prevent a crash on invalid input, but that's probably a subjective design decision. Repositor

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler updated this revision to Diff 274071. ckandeler added a comment. Fixed formatting issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82629/new/ https://reviews.llvm.org/D82629 Files: clang/test/Index/evaluate-cursor.cpp clang/tool

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler created this revision. ckandeler added a reviewer: milianw. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. When a variable-length array is being captured in a lambda, the AST contains two captures, the first one having a null init expression. Visiting tha