sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
LGTM with comment addressed.
Comment at: clang/lib/Basic/Targets/AArch64.cpp:325
+ if ((FPU & SveMode) && HasMatmulInt8)
+Builder.defineMacro("__ARM_FEATURE_SVE_MA
sdesmalen added a comment.
Hi @fpetrogalli , I see the patch is still missing a few tests to
`clang/test/Preprocessor/aarch64-target-features.c`.
Not specifically to be done in this patch, but we'll also needs changes to make
sure that the bfloat macros are set for armv8.6 (e.g. `-march=armv8.6
fpetrogalli added a comment.
Reviewers, I have added 2 parent revision with the last two set of intrinsics
that are enabled by the macro introduced in this patch. I will update those
tests in this patch once the patches are in. Meanwhile, please double check
that my interpretation of the featur
fpetrogalli created this revision.
fpetrogalli added reviewers: sdesmalen, efriedma, c-rhodes, kmclaughlin,
SjoerdMeijer.
Herald added subscribers: cfe-commits, psnobl, rkruppe, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: clang.
fpetrogalli added parent revi