[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2706 + + For example: STRINGIZE + JakeMerdichAMD wrote: > curdeius wrote: > > Shouldn't there be a configuration example like what's in `ForEachMacros` > > doc? > > ``` > >

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c332a7784c6: [clang-format] Preserve whitespace in selected macros (authored by JakeMerdichAMD). Changed prior to commit: https://reviews.llvm.org/D82620?vs=273722&id=274102#toc Repository: rG LLVM

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

curdeius accepted this revision. curdeius added a comment. LGTM. Thank you for taking my comments into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82620/new/ https://reviews.llvm.org/D82620

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82620/new/ https://reviews.llvm.org/D82620 ___

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

JakeMerdichAMD added a comment. Thanks for the fast review, @curdeius, and thanks for mentioning PP_STRINGIZE and BOOST_PP_STRINGIZE too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82620/new/ https://reviews.llvm.org/D82620 _

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

JakeMerdichAMD updated this revision to Diff 273722. JakeMerdichAMD marked 3 inline comments as done. JakeMerdichAMD added a comment. Address feedback (nits, better docs, more defaults) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82620/new/ https

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

JakeMerdichAMD marked 10 inline comments as done. JakeMerdichAMD added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2706 + + For example: STRINGIZE + curdeius wrote: > Shouldn't there be a configuration example like what's in `ForEachMacro

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2706 + + For example: STRINGIZE + Shouldn't there be a configuration example like what's in `ForEachMacros` doc? ``` In the .clang-format configuration file, this can be configu

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

JakeMerdichAMD created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. JakeMerdichAMD added reviewers: MyDeveloperDay, curdeius, sammccall, jbcoe. JakeMerdichAMD added a project: clang-format. https://bugs.llvm.org/show_bug.cgi?id=46383 When the